Skip to content

Add Analytics SetConsent method, with test. #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Dec 17, 2022
Merged

Add Analytics SetConsent method, with test. #560

merged 37 commits into from
Dec 17, 2022

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Dec 3, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@jonsimantov jonsimantov changed the title Add test for Analytics SetConsent method. Add Analytics SetConsent method, with test. Dec 6, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 15, 2022
@github-actions
Copy link

github-actions bot commented Dec 15, 2022 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit refs/pull/560/merge
Last updated: Thu Dec 15 17:50 PST 2022
View integration test log & download artifacts

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 15, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 15, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels Dec 15, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 16, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 16, 2022
@jonsimantov jonsimantov marked this pull request as ready for review December 16, 2022 00:55
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels Dec 16, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Dec 16, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 16, 2022
a-maurice
a-maurice approved these changes Dec 16, 2022
View reviewed changes
@jonsimantov jonsimantov merged commit a5dc49c into main Dec 17, 2022
@jonsimantov jonsimantov deleted the analytics-setconsent branch December 17, 2022 00:13
mrober pushed a commit that referenced this pull request Jan 3, 2023
@jonsimantov @a-maurice @mrober
Add Analytics SetConsent method, with test. (#560)
f29f500 
* Add test for Analytics SetConsent method.

* Add std_map swig include.

* Update SWIG wrapper to create SetConsent(IDictionary)

* Add namespace

*  Fix up the ConsentMap, and the Internal function

* Remove commented out using statements

Co-authored-by: a-maurice <amaurice@google.com>
@themiswang themiswang mentioned this pull request Jan 3, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-maurice a-maurice a-maurice approved these changes

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

Assignees

@a-maurice a-maurice

Labels

tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonsimantov @a-maurice